-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Fixed XAML data binding failure #11574
Conversation
How can I reproduce this issue? |
I just build and run the app, and the issue comes up. I guess it can be reproduced when using details view and enabling checkboxes? Because |
I think there is an existing converter that we can use. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I removed the binding, and merged |
This is already being done in #11552 |
I also simplify some code in the converter classes. But I can restore it if necessary. |
@Poker-sang thank you for your contribution, in general we prefer to limit the scope of PRs to the related issue/feature. As per the contribution guidelines, it's strongly recommended to open an issue and wait for an org member to approve it before opening the PR. This is more for the contributors benefit than ours because it helps everyone be on the same page and avoids duplicate work. |
I am sorry. I just encountered a XAML failure and tried to fix it. If this PR was duplicated, please close it. I will pay more attention to this from now on. |
The data binding fix is good but the name spaces changes are being done in another PR. |
I will revert it. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolved / Related Issues
Items resolved / related issues by this PR.
Details
When opening a file list,
CheckBox.Width
's data binding failed for there's noGridLengthToDouble
converterValidation
How did you test these changes?